Repository navigation
feat(ui): add just ui-serve to look at a UI change locally - #101
Merged
Merged
Conversation
- just ui-serve builds the viewer and serves it with the committed real data, port 4400 by default - the test server now listens on 127.0.0.1 only, and the browser tests use that address - ui/README.md says how to look at a UI PR: ui-serve, or CI's ui-screenshots artifact Signed-off-by: Simon van Lierde <simonvanlierde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no quick way to look at a UI change before merging it. Now
gh pr checkout <n>thenjust ui-serveshows it.just ui-serve [port]builds the viewer and serves it with the committed real data, on port 4400 by default. From a laptop:ssh -L 4400:localhost:4400to the host.ui/README.mdnames both ways to look at a UI PR:ui-serve, or theui-screenshotsartifact CI keeps for 14 days.Tests: Playwright 23 passed against 127.0.0.1;
just ui-serve 4417served the page anddata/index.json, listening on 127.0.0.1 only.