tests: fix nametabletest NameRecord conversion bounds#106
Open
bgermann wants to merge 1 commit intosilnrsi:masterfrom
Open
tests: fix nametabletest NameRecord conversion bounds#106bgermann wants to merge 1 commit intosilnrsi:masterfrom
bgermann wants to merge 1 commit intosilnrsi:masterfrom
Conversation
The synthetic name-table builder copied one too many NameRecord entries in toBigEndian(). FontNames already contains name_record[0], while m_records stores only the remaining count-1 records. The loop used count, so for NameTestB (count=8, m_records[7]) it wrote past m_records and corrupted adjacent fields (m_langTagCount/lang tags). That memory corruption breaks format 1 language-tag lookup and causes fallback behavior. Fixes: silnrsi#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synthetic name-table builder copied one too many NameRecord entries in toBigEndian().
FontNames already contains name_record[0], while m_records stores only the remaining count-1 records. The loop used count, so for NameTestB (count=8, m_records[7]) it wrote past m_records and corrupted adjacent fields (m_langTagCount/lang tags).
That memory corruption breaks format 1 language-tag lookup and causes fallback behavior.
Fixes: #96