Allow float width/height in document page Size - #71
Open
Dinwid wants to merge 1 commit into
Open
Conversation
The API returns non-integer page dimensions for some documents (e.g. 791.99), which causes a TypeError in Size::fromArray() because the constructor is typed int under strict_types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GET /document/{document_id}can return non-integer page dimensions inpages[].size, e.g.:Since
Sizeis declared understrict_types=1withintconstructor parameters,Size::fromArray()throws an uncatchable-in-practiceTypeErrorwhenever the API returns a float, which breaksDocumentGetdeserialization for such documents.Fix
Widen
width/heightinSignNow\Api\Document\Response\Data\Sizefrominttofloat|int(constructor and getters). Integer values keep round-tripping as integers throughtoArray(); float values no longer fatal.phpcspasses on the changed file.