Open
Conversation
This reverts commit 9e711e2. We cannot just uname these unused parameters because gcc 10 need them. There will be error like below with gcc 10: lib/copydir.c:103:11: error: parameter name omitted Fixes: shadow-maint#1530 Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
This reverts commit 0663ba2. Fixes: shadow-maint#1530 Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Fixes: shadow-maint#1530 Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Fixes: shadow-maint#1530 Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
|
|
||
| static void | ||
| login_exit(int) | ||
| static void login_exit (MAYBE_UNUSED int sig) |
Collaborator
There was a problem hiding this comment.
If we really need to fix the regression, I'd like to not revert the commits. Instead, please call the parameters _ in a new commit. When there is more than one, please call them _, __, ___, etc.
Author
There was a problem hiding this comment.
Got it. I'll squash these into one patch and use parameters like '_'.
Collaborator
There was a problem hiding this comment.
Sorry, after some thought, _ will collide with the _() function from GNU gettext. Also, __ is a reserved identifier.
So, we'll need _1, _2, ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the error for gcc10:
error: parameter name omitted