Skip to content

src/vipw.c: Some readability improvements#1506

Open
alejandro-colomar wants to merge 4 commits intoshadow-maint:masterfrom
alejandro-colomar:vipw_tcb
Open

src/vipw.c: Some readability improvements#1506
alejandro-colomar wants to merge 4 commits intoshadow-maint:masterfrom
alejandro-colomar:vipw_tcb

Conversation

@alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Jan 15, 2026

I find this file quite hard to read. This improves the situation a little bit, although more follow-up work is needed.


Revisions:

v1b
  • Rebase
$ git rd 
1:  a8424d5fea62 = 1:  da6671ec2a5d src/vipw.c: vipwedit(): Reduce scope of local variable
2:  141b7078a631 = 2:  4154cf22ee7d src/vipw.c: vipwexit(), usage(): Mark as [[noreturn]]
3:  fead1f4fc4c9 = 3:  eda0b4f6fb45 src/vipw.c: vipwedit(): Don't else after [[noreturn]]
4:  b34974d7e7cf = 4:  3d311a157cb1 src/vipw.c: vipwedit(): Set fileedit closer to its use

@alejandro-colomar alejandro-colomar marked this pull request as ready for review January 15, 2026 15:35
'f' is already used for something else before.  Create a new variable
used only for this, and limit it to this block.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant