Test/ci after fixes#7
Merged
Merged
Conversation
…kySurge compile-game.sh: the C# branch built up a custom compile string but never executed it (no eval), so any compile-command= for a C# game was silently ignored. The C++ branch already had eval $command — this is the missing companion. With that fix, 2dRacer and SkySurge can now use compile-command to disambiguate their projects: - 2dRacer has no .csproj at the root (two demos in AdvancedDemo/ and BasicDemo/); publish AdvancedDemo/_2dRacerDemo.csproj explicitly - SkySurge has both "Sky Surge.sln" and Sky_Surge.csproj at the root, which makes dotnet publish ambiguous; pin it to the .csproj
BelowTheSurface: the previous attempt switched center_point(sprite) to center_point(sprite_collision_rectangle(...)), but the SplashKit build installed by skm linux install also lacks a rectangle overload. Compute the center inline from sprite_x/y/width/height so the code does not depend on any geometry overload that the live SplashKit may or may not ship. Pingpong: enabling compile-command=skm g++ *.cpp surfaced 5 more to_string ambiguities in game.cpp (only program.cpp was visible before, since the default command compiled a single file). Same fix as the others — qualify std::to_string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Testing Checklist
Checklist