Add ::file-selector-button pseudo-element#341
Merged
mrobinson merged 1 commit intoservo:mainfrom Mar 26, 2026
Merged
Conversation
Member
Author
|
Do I need to do something special to make this support the hover pseudo class? I'm not sure if Servo's version of stylo supports chaining pseudo-classes after pseudo-elements yet. |
mrobinson
approved these changes
Mar 24, 2026
Co-authored-by: Vasiluță Mihai-Alexandru <alexv@siluta.me> Signed-off-by: Luke Warlow <lwarlow@igalia.com>
lukewarlow
force-pushed
the
file-selector-button
branch
from
1f52efa to
10c54cc
Compare
Member
|
@lukewarlow Does this have a corresponding Servo change? |
Member
Author
|
Yes it's servo/servo#43498 - I'm just rebasing that one now |
Member
Author
|
That's rebased now and unmarked as draft. |
Member
|
Landing this so that you can then land the Servo change. |
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 27, 2026
script: Implement shadow tree for file input File inputs also now support ::file-selector-button Testing: Existing WPTs Fixes: #39565 Stylo PR: servo/stylo#341 Signed-off-by: Luke Warlow <lwarlow@igalia.com> Co-authored-by: Vasiluță Mihai-Alexandru <alexv@siluta.me>
lando-worker bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 3, 2026
…firefox-style-system-reviewers,emilio Imports servo/stylo#341 Differential Revision: https://phabricator.services.mozilla.com/D291914
github-actions bot
pushed a commit
to longvatrong111/stylo
that referenced
this pull request
Apr 4, 2026
…firefox-style-system-reviewers,emilio Imports servo#341 Differential Revision: https://phabricator.services.mozilla.com/D291914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #245 but needed a rebase. Have added original author under Co-authored-by to maintain credit.