Repository navigation
Fix Bedrock Astra caching surface guidance - #46
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bedrock reference categorically restricted GPT-6 Astra caching to Responses and applied Responses-shaped usage/accounting claims to it. AWS's guide and Astra card support explicit caching on Runtime Chat Completions and InvokeModel, while Converse supports implicit caching only. A valid Chat Completions configuration could therefore receive a false unsupported-surface finding and an unnecessary migration recommendation.
Remove Astra from the GPT-5.6-only paragraph and link it, per its own card, to the existing surface, placement, minimum and usage-ambiguity guidance. Explicitly exclude Sol's Routes bullet because Astra routes and tiers differ. Only original
bedrock.mdlines 20–21 change: 8,391 → 8,319 characters (−72); every other line is byte-identical. GPT-5.6 support wording is preserved apart from unsharing Astra.Evidence and VALUE gate:
input_textfor Responses andtextparts for Chat Completions/InvokeModel; no explicit Converse caching.b2729b952c356010bddcae804b50485872a142a844b53bd7ade0faf2b8cc82f8; Astra card1fb4dca684852c76d971fcc779b57a6042b40ee62b73cba571c04c2a743c95db. Direct fresh HTML captures matched the accepted captures. Fresh base4784358cdcd2df9900107a8e0bc03abe367c6a7f; relevant reference, SKILL and rules blobs match the accepted gate.Fresh local verification output:
Static evaluation (
plugin-eval analyzebefore/after, thencompare): trigger estimate 152 unchanged; invocation estimate 6,700 unchanged; deferred estimate 95,329 → 95,311 (−18). Score remains 59/D, with the same pre-existing budget/structure/code warnings and no new failures. No budget ceiling changed. These are static estimates.Targeted inspection results, with criteria fixed before runs:
textbreakpoint, 30m, ≥1,024 prefix, low reads and writes presentcachePointBoth were informed before/after inspections, not blind experiments. No behavioral uplift, cache hit, per-route usage schema/accounting, ROI or production outcome is claimed. Existing source lookup already compensated for the old contradiction. No new durable eval/test or script behavior change was required.
Independent fresh read-only review (Opus 5.5 high): APPROVE, no blocking findings. It verified C1–C5, the exact two-line diff, source contracts and both before/after inspections; the Routes/tier exclusion is unambiguous. Remaining limits are shared-bullet drift and unchanged generic diagnostics outside the accepted scope. No runtime behavior was tested.
GitHub CI verification output:
validatepassed for head1cf6ea35eaa7f62fde5f6fc2bfde9556b716d845(run completed 2026-10-20T09:07:18Z); all script tests, package validation, trigger summary, syntax, whitespace and bytecode checks passed.