Repository navigation
Correct Kimi Messages default cache writes - #45
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kimi Messages guidance and evals 37/45 still described omitted top-level
cache_controlas read-only. The current Chinese-platform docs describe default 5m reads and writes instead. This repairs those rules and preserves the distinction between zero writes reported by one request and write behavior across requests.Only the affected Moonshot reference sentences, a dated Messages API source link, and
expected_outputof existing evals 37/45 change. Full prefix hits can normally report zero creation; check reads first. In-message markers remain ignored, and top-level controls select TTL. Deployment behavior remains unverified.Evidence and VALUE gate
31a2e242f0c7b546afaf444b42d10d0bd6c8b47d, unchanged affected blobs and matching primary captures. The basis is a deterministic documentation/eval contradiction, with no tenant or causal benefit claim.Last reviewedbump.Verification and review receipts
python3 -m unittest discover -s tests -p 'test_*.py': 260 tests OK.git diff --check, bytecode cleanup/absence: pass.Evaluation results and limits
Static
plugin-eval analyzeandcompare: 59/D → 59/D; trigger 152, invoked 6,700 and per-file deferred 95,329 estimates unchanged. Existing budget/complexity warnings remain; this is structure/budget evidence only.Two blind scenarios each ran before and after in four fresh
claude-bOpus 5.5/high sessions with identical per-scenario prompts and ordinary read-only primary-source lookup:All four accounted 24,888 total input without counting the TTL write breakdown twice. There is no demonstrated failure-to-pass or production benefit. The after-B answer still predicts a hypothetical TTL-switch write despite a verification caveat; that broader extrapolation is unproven and is not treated as general behavioral acceptance. No reruns were used to seek a preferred answer.
Full captures, preregistered criteria, answers, journals and command receipts are preserved outside the product repository. They contain local execution metadata and are excluded from the commit. No merge, release, deployment or production probe was performed.