Repository navigation
Add optional Numba spatial-grid neck detector - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional exact Numba spatial-grid backend for neck-cutoff detection.
The existing SciPy KDTree implementation remains the default and reference path.
New public control:
The neck detector backend is independent of both the flow backend and the geometry unwrap backend.
Implementation
d² < r²).isemantics.jselection.jtie-breaking.kdtreeas the default backend.numba_gridis explicitly requested without Numba installed.Exactness
The benchmark prototype matched the KDTree reference on:
The public production-path validation also matched exactly through both 1,000 and 5,000 steps.
At 5,000 steps both backends produced:
Ns = 2359;1.7245401220504077;Performance
For the validated case-1 5,000-step benchmark prototype, three paired runs gave:
The final warmed public-production candidate profile measured:
These timings are machine- and workload-specific and are not universal performance guarantees.
Compatibility
kdtree.run_casepositional argument order is preserved.Validation
pytest: pass, one expected skip.py_compile: pass.git diff --check: pass.Notes
The numerical-safety fallback is not automatic backend selection and is not a dependency fallback. The selected backend remains
numba_grid; only an individual detector call delegates to the KDTree reference when the integer spatial-grid representation is unsafe.