Repository navigation
Fix solver validation, history semantics, and Numba parity - #46
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f6679b35e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| flow_paral=config.run.flow_paral, | ||
| flow_workers=config.run.flow_workers, | ||
| flow_backend=config.run.backend, | ||
| output_units=scales["resolved_output_units"], |
There was a problem hiding this comment.
Validate the requested GUI output units
Pass config.run.output_units to the validator rather than the resolved value. output_scales() maps every unrecognized value to "dimensionless", so a loaded or programmatically constructed GUI config with a typo such as "dimensionl" passes validation and silently produces dimensionless scientific outputs instead of reporting the invalid unit selection.
Useful? React with 👍 / 👎.
Summary
Second corrective review round for LDSFL-Meander.
Fixes
Validation
Scope
No physical model equations, resonance formulation, resistance/update ordering, or applicability thresholds were changed.
Package version remains 0.6.5.