Skip to content

Fix review findings and add regression tests - #45

Merged
sergioald merged 1 commit into
mainfrom
fix/review-findings-sep2026
Sep 18, 2026
Merged

sergioald merged 1 commit into
mainfrom
fix/review-findings-sep2026

Conversation

@sergioald

Copy link
Copy Markdown
Owner

This PR addresses six issues identified during an independent review of LDSFL_Meander.

Fixes:

  • Correct direct bed-shear-stress to Shields-stress conversion.
  • Preserve previous simulation outputs by isolating repeated runs.
  • Preserve dimensional output scaling during GUI continuation.
  • Select batch cases using the actual Parameter.csv IDs.
  • Correct stop_mode="all" handling for inactive limits.
  • Avoid copying full sinuosity histories for moving-window diagnostics.

Additional changes:

  • Added regression tests for the corrected behaviour.
  • Updated user documentation and changelog.

Validation:

  • 175 tests passed
  • 1 environment-dependent test skipped
  • 1 pre-existing expected failure remains for the known Numba SL=1 discrepancy

@sergioald
sergioald merged commit 75989a7 into main Sep 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant