2892_Edit_templates_in_admin_pages

[lilitkarapetyan]

NOTE: Converted to draft, since we can only merge it once we've fully moved to the new template model.

Fixes #2892

🧰 Issue

🚀 Overview:

🔗 Link to preview

🤔 Reason:

🔨Work carried out:

• Tests pass

🖥️ Screenshot

Confirmations

• I have chosen reviewers for my PR.
• I have assigned myself to this PR.
• I have chosen an appropriate label for the PR.
• I have completed the mandatory sections of this document.
• I have deleted any unused sections.
• I confirm that I have checked for required README updates and acted accordingly.

📝 Developer Notes:

[lilitkarapetyan]

fixes #2892

[Tristina1788]

@IanMayo , @lilitkarapetyan Tested on '2892_Edit_templates_in_admin_pages' , Now I can see the new tab 'Template' for wargame

But I see some issues on this feature :

• Can't rename a template which has created

unable-to-rename-new-template.mp4

• Message for duplicate template is incorrect

• Create/Rename a template and it shows incorrect message. (only one template is saved, not multiple templates. So we should update it)

• Text 'CREATE TEMPLATE LIST' is incorrect

• It shows white screen when delete all template name

white-screen-delete-template-name.mp4

[lilitkarapetyan]

@IanMayo , @lilitkarapetyan Tested on '2892_Edit_templates_in_admin_pages' , Now I can see the new tab 'Template' for wargame

But I see some issues on this feature :

* Can't rename a template which has created

unable-to-rename-new-template.mp4

* Message for duplicate template is incorrect

* Create/Rename a template and it shows incorrect message. (only one template is saved, not multiple templates. So we should update it)

* Text 'CREATE TEMPLATE LIST' is incorrect

* It shows white screen when delete all template name

white-screen-delete-template-name.mp4

Hello @Tristina1788 , I appreciate your input. I will definitly look into it and improve it. Thank you

[IanMayo]

Hello @Tristina1788 , I appreciate your input. I will definitly look into it and improve it. Thank you

You're right @lilitkarapetyan - that's great feedback @Tristina1788

[Tristina1788]

Tested on '2892_Edit_templates_in_admin_pages'

Above issues are still happened. Only some issues are fixed as below

• Text 'CREATE TEMPLATE LIST' is correct

• Enable to rename a template which has created

@lilitkarapetyan Please help to fix another issues

[lilitkarapetyan]

Tested on '2892_Edit_templates_in_admin_pages'

Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

* Enable to rename a template which has created

@Lil

Tested on '2892_Edit_templates_in_admin_pages'

Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

* Enable to rename a template which has created

@lilitkarapetyan Please help to fix another issues

Hello @Tristina1788 Please shere the details of the issue, and I'll be more then happy to assist you.

[Tristina1788]

Tested on '2892_Edit_templates_in_admin_pages'
Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

* Enable to rename a template which has created

@Lil

Tested on '2892_Edit_templates_in_admin_pages'
Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

* Enable to rename a template which has created

@lilitkarapetyan Please help to fix another issues

Hello @Tristina1788 Please shere the details of the issue, and I'll be more then happy to assist you.

Hi @lilitkarapetyan , I mean these issue are still happened.

• Message for duplicate template is incorrect. It should be 'Template is duplicated'

• Create/Rename a template and it shows incorrect message. (only one template is saved, not multiple templates. So we should update it) => It should be 'Template is saved'

• Delete all name of template make a full white screen. We need to refresh to go to admin page again.

white-screen-delete-template-name.mp4

[IanMayo]

@lilitkarapetyan - I've made a commit that tries to handle old wargames more robustly. Could you check it makes sense, please?

[lilitkarapetyan]

@lilitkarapetyan - I've made a commit that tries to handle old wargames more robustly. Could you check it makes sense, please?

Yes I will check now.

[lilitkarapetyan]

Tested and working

[Tristina1788]

@lilitkarapetyan @IanMayo

Now the description shows white color as expected

I can click 'Template' on 'P10 Test' game without white screen and can create a new template on this game

I'm checking more to see if any new issue.

[Tristina1788]

@lilitkarapetyan @IanMayo Now multi fiels on rows can't work as before (It can show correctly on 'Preview form' but it can't work on game play)

• Field with type 'Long Answer' still keep cache text after send message

2024-08-07_14-32-10.mp4

• The button in array field shows not good from 'Preview form' and game play

• Description of field is hard to see from 'Preview Form' (It's white as backgroud so user can't see it)

[Tristina1788]

@lilitkarapetyan Field with type 'Long Answer' still keep cache text after send message is fixed as expected .

[Tristina1788]

@lilitkarapetyan @IanMayo

• The multi rows fields show difference from 'Preview Form' (Max default fields on row is 7) and game play (Max default fields on row is 7)
  

• The 'Send Message' and input fields should has space

• I think the default should be each field on one line ( I mean default size can be 11 or 12 instead of 1.5 as current )

• Detail message of Blue WA channel is quite hard to see. I think it's better with original detail on develop branch

• Template with form element and section shows not good (Example : 'Wa Message' template)

• Get erros on 2 pages on story book (It's not happened on 'develop' branch)

http://localhost:6611/?path=/story/local-collabstatusboard--collaborative-edit-editor
http://localhost:6611/?path=/story/local-organisms-coremapping--default

[Tristina1788]

@lilitkarapetyan @IanMayo
Template with form element and section shows not good (Example : 'Wa Message' template, from the 'Visual Form Build' , Id and Weapon are above section Threat, but from 'Preview Form' and Game Play, Id and Weapon are below section Threat )

• 'Send Message' and 'Cancel' are in wrong position and the sizes of buttons are not good

• Description field makes the next field move to right

[Tristina1788]

• Template with form element and section shows well now

• 'Description field makes the next field move to right' => It's fixed as expected

• 'Send Message' and 'Cancel' are in correct position. But I think it's better to have a little space with scoll bar

I'm checking more.

[Tristina1788]

@lilitkarapetyan @IanMayo

• Description of checkbox is not showed in 'Preview Form' and GamePlay

• Detail of sent message should show by Display Name instead of Object Name

• Button action of Item in Array field still show not good when it has description. Action button should align with input row

• Core Mapping of Story book still has error (http://localhost:6611/?path=/story/local-organisms-coremapping--default)

• Error message for field makes the next field move to right

[lilitkarapetyan]

• Template with form element and section shows well now

* 'Description field makes the next field move to right' => It's fixed as expected

* 'Send Message' and 'Cancel' are in correct position. But I think it's better to have a little space with scoll bar

I'm checking more.

In that case, we neeed to make the Display Name and Object Name the same.