Repository navigation
refactor(sandbox): delegate native shell lifecycle to TinyBox - #685
Merged
senamakel merged 4 commits intoOct 26, 2026
Merged
Conversation
Replace the local OS sandbox backend detection and shell execution plumbing with the tinybox-jail crate, bumping the vendored tinybox dependencies to 0.2.4. This removes duplicated platform detection logic and routes shell execution through the shared jail implementation. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Moved policy resolution and execution routing out of the monolithic ops module into dedicated policy and exec submodules, leaving ops.rs as a thin re-export surface. This keeps host policy decisions separate from backend execution adapters so each can evolve independently. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Replace the glob re-exports in the sandbox ops module with explicit re-exports, gating test-only helpers behind cfg(test) and internal helpers as pub(crate). This keeps the public surface intentional and avoids leaking implementation details. The TinyBox dependency is bumped to v0.2.4 and the ignored native jail test now references that release. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
senamakel
merged commit Oct 26, 2026
683ccd2
into
epic/8369-security-migration
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_native_shellfrom v0.2.4.ProcessCleanup::holdworker supervision, request policy and configuration translation, progress metering, fixture, andLiveShellhandle ownership.backend_name().279dcef; SHA-256 values were copied verbatim fromhttps://github.com/senamakel/tinybox/releases/tag/v0.2.4checksum.toml.tinybox-coredev-dependency. TinyBox lifecycle implementation and lifecycle tests are already covered upstream in [core-shrink] add TinyBox native shell client helper tinybox#61.Verification
Passed: feature-enabled root cargo check, app cargo check, core Clippy with
-D warnings, rustfmt, focused shell adapter tests (7), and shell process lifecycle tests (12).check-submodule-monotonicand TinyBox'spin-statuspass for this pin.Known environment/repository blockers:
check-module-pinscannot describe the existingvendor/tinyeventqueuescheckout;pnpm rust:layoutreaches existing core baseline-growth failure incredentials/profiles/persistence.rs; module-disabled no-default compilation hits existing channel cfg references; the optional released-artifact jail test cannot run because this container's Linux jail cannot satisfy its isolation floor.Part of tinyhumansai#8369.
Closes #377