Add read buffer to SnoopFileReader.#2086
Merged
Dimi1010 merged 1 commit intoseladb:devfrom Mar 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2086 +/- ##
==========================================
- Coverage 84.01% 84.00% -0.01%
==========================================
Files 316 316
Lines 56963 56958 -5
Branches 12020 12041 +21
==========================================
- Hits 47856 47849 -7
- Misses 8315 8317 +2
Partials 792 792
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seladb
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the read buffer implementation of
PcapFileReaderDevicein #2072 toSnoopFileReaderDevice.This defers the allocation of a packet buffer until after the packet has been confirmed to match all filters and needs to be extracted. It also precisely sizes the needed buffer, reducing wasted space.