Skip to content

fix: standardize package publishing hygiene (PLT-847) #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-sei merged 4 commits into from
Aug 11, 2026
Merged

fix: standardize package publishing hygiene (PLT-847) #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3aea8e0
fix: standardize package publishing hygiene
alexander-sei Aug 9, 2026
6021b13
fix: preserve global wallet ISC license
alexander-sei Aug 9, 2026
4d8081c
fix: resolve packaging review feedback
alexander-sei Aug 10, 2026
2fb5145
fix: address follow-up package review
alexander-sei Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/tidy-package-publishing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@sei-js/create-sei": patch
"@sei-js/ledger": patch
"@sei-js/mcp-server": patch
"@sei-js/precompiles": patch
"@sei-js/registry": patch
"@sei-js/sei-global-wallet": patch
---

Standardize published package contents, licensing, and type resolution.
3 changes: 3 additions & 0 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,6 @@ jobs:

- name: Test
run: pnpm test:all

- name: Validate Published Packages
run: pnpm lint:pack:all
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ jobs:
- name: Build Packages
run: pnpm build:all

- name: Validate Published Packages
run: pnpm lint:pack:all

- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@v1
Expand Down
7 changes: 7 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
"license": "MIT",
"scripts": {
"build:all": "pnpm -r run build",
"lint:pack:all": "pnpm lint:pack:publint && pnpm lint:pack:types && pnpm lint:pack:types:mcp",

@seidroid seidroid Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Chaining with && means a publint failure short-circuits before ATTW ever runs, so a CI run surfaces one class of packaging problem at a time. Minor, but for a validation aggregate it's usually nicer to run all three and fail at the end.

"lint:pack:publint": "pnpm --recursive --filter './packages/*' exec publint --pack npm --strict --level warning",
"lint:pack:types": "pnpm --recursive --filter './packages/*' --filter '!@sei-js/create-sei' --filter '!@sei-js/mcp-server' exec attw --pack . --profile node16",
"lint:pack:types:mcp": "pnpm --filter @sei-js/mcp-server exec attw --pack . --profile esm-only",
"release": "changeset publish && git push --follow-tags",
"release:internal": "pnpm build:all && pnpm changeset && pnpm changeset version --snapshot internal && pnpm changeset publish --no-git-tag --snapshot --tag internal",
"test:all": "pnpm -r run test",
Expand All @@ -15,9 +19,12 @@
"@changesets/cli": "^2.28.1"
},
"devDependencies": {
"@arethetypeswrong/cli": "0.18.5",
"@types/jest": "^29.5.14",
"@types/node": "^22.13.13",
"esbuild": "^0.28.2",

@seidroid seidroid Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] publint and @arethetypeswrong/cli are exact-pinned, but esbuild is a caret range — and unlike the other two it now produces the published artifacts for three packages. The lockfile covers CI, but pinning it exactly matches the intent of the other two pins and keeps published output reproducible.

Separately: esbuild is only a root devDependency while packages/{ledger,precompiles,registry} invoke it from their own build scripts. That resolves today via pnpm putting the workspace-root .bin on PATH, but breaks if any of those packages is ever built standalone. Declaring it as a devDependency of the three packages that use it would be more robust.

"jest": "^29.7.0",
"publint": "0.3.23",
"rimraf": "^3.0.2",
"ts-jest": "^29.3.0",
"ts-node": "2.1.2",
Expand Down
21 changes: 21 additions & 0 deletions packages/create-sei/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2024-2026 Sei Labs

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
9 changes: 9 additions & 0 deletions packages/create-sei/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,23 @@
{
"name": "@sei-js/create-sei",
"version": "1.0.1",
"description": "Scaffold new Sei applications with pre-configured templates and tooling",
"homepage": "https://github.com/sei-protocol/sei-js/tree/main/packages/create-sei#readme",
"repository": {
"type": "git",
"url": "https://github.com/sei-protocol/sei-js.git",
"directory": "packages/create-sei"
},
"license": "MIT",
"module": "dist/main.js",
"type": "module",
"bin": "./dist/main.js",
"files": [
"dist"
],
"publishConfig": {
"access": "public"
},
"scripts": {
"build": "rm -rf dist && tsc && chmod +x dist/main.js && rsync -av --exclude-from=.rsyncignore ./templates/ ./dist/templates/ && rsync -av --exclude-from=.rsyncignore ./extensions/ ./dist/extensions/",
"dev": "node --loader ts-node/esm src/main.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sei/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": "../../tsconfig.base.json",
"exclude": ["node_modules", "dist", "test"],
"exclude": ["node_modules", "dist", "test", "**/*.spec.ts", "**/*.test.ts", "**/*.spec.js", "**/*.test.js", "**/__tests__/**/*"],
"compilerOptions": {
"outDir": "./dist",
"target": "ES2020",
Expand Down
21 changes: 21 additions & 0 deletions packages/ledger/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2024-2026 Sei Labs

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
4 changes: 2 additions & 2 deletions packages/ledger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.1.6",
"description": "TypeScript library for SEI Ledger app helper functions",
"main": "./dist/cjs/src/index.js",
"module": "./dist/esm/src/index.js",
"module": "./dist/esm/src/index.mjs",
"types": "./dist/types/src/index.d.ts",
"sideEffects": false,
"files": [
Expand All @@ -12,7 +12,7 @@
"scripts": {
"build": "rimraf dist && pnpm run build:cjs && pnpm run build:esm && pnpm run build:types",
"build:cjs": "tsc --outDir dist/cjs --module commonjs",
"build:esm": "tsc --outDir dist/esm --module esnext",
"build:esm": "esbuild src/index.ts --bundle --format=esm --platform=neutral --packages=external --target=es2020 --outfile=dist/esm/src/index.mjs",
Comment thread
alexander-sei marked this conversation as resolved.

@seidroid seidroid Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Two notes on the esbuild switch, both of which also apply to precompiles and registry:

  1. The bundle is only reachable through the non-standard module field. With no exports map, Node ESM import '@sei-js/ledger' still resolves main → dist/cjs/src/index.js (CJS), so the ESM/CJS entrypoint fix stated in the PR description lands only for bundlers. Adding an exports map would make it real and bring the .mjs under ATTW's node16 profile.
  2. Renaming the output .js → .mjs opts webpack into javascript/esm module type instead of javascript/auto, which enforces strict ESM interop. Named imports from CJS-only deps that previously worked can start failing — for ledger specifically, import { SeiApp } from '@zondax/ledger-sei'. Worth confirming against a real bundler consumer before release; import Transport from '@ledgerhq/hw-transport-node-hid' (default import) is fine either way.

"build:types": "tsc --project ./tsconfig.declaration.json",
"test": "jest"
},
Expand Down
11 changes: 6 additions & 5 deletions packages/mcp-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,15 @@
"bin": "./bin/mcp-server.js",
"main": "./dist/esm/index.js",
"module": "./dist/esm/index.js",
"types": "./dist/types/index.d.ts",
"files": [
"dist/",
"bin/",
"README.md",
"LICENSE"
"dist",
"bin"
],
"scripts": {
"build": "rm -rf dist && tsc",
"build": "rm -rf dist && pnpm run build:esm && pnpm run build:types",
"build:esm": "tsc --project ./tsconfig.build.json",
"build:types": "tsc --project ./tsconfig.declaration.json",
"start": "node dist/esm/index.js",
"start:http": "node dist/esm/index.js --streamable-http",
"start:http-sse": "node dist/esm/index.js --http-sse",
Expand Down
4 changes: 4 additions & 0 deletions packages/mcp-server/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"extends": "./tsconfig.json",
"exclude": ["node_modules", "dist", "src/tests/**/*", "**/*.spec.ts", "**/*.test.ts", "**/*.spec.js", "**/*.test.js", "**/__tests__/**/*"]

@seidroid seidroid Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] This exclude is byte-identical to the one added to tsconfig.json in the same PR, so tsconfig.build.json currently inherits everything and overrides nothing. Either drop this file and point tsconfig.declaration.json back at tsconfig.json, or drop the exclude from tsconfig.json and let this file be the thing that carries it. As-is the two lists will silently drift.

}
2 changes: 1 addition & 1 deletion packages/mcp-server/tsconfig.declaration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "./tsconfig.json",
"extends": "./tsconfig.build.json",
"compilerOptions": {
"outDir": "./dist/types",
"declaration": true,
Expand Down
6 changes: 4 additions & 2 deletions packages/mcp-server/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
{
"extends": "../../tsconfig.base.json",
"include": ["src"],
"exclude": ["node_modules", "dist", "src/tests/**/*", "**/*.spec.ts", "**/*.test.ts", "**/*.spec.js", "**/*.test.js", "**/__tests__/**/*"],
"compilerOptions": {
"rootDir": "./src",
"outDir": "./dist/esm",
"moduleResolution": "node",
"module": "ES2020",
"moduleResolution": "Node16",
Comment thread
alexander-sei marked this conversation as resolved.
"module": "Node16",
"target": "ES2020"
}
}
5 changes: 4 additions & 1 deletion packages/mcp-server/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
"compilerOptions": {
"types": ["jest", "node"],
"isolatedModules": true,
"resolveJsonModule": true
"resolveJsonModule": true,
"module": "ES2020",
"moduleResolution": "Bundler"

@seidroid seidroid Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] This project now resolves to zero input files. tsconfig.json gained "exclude": [..., "src/tests/**/*", "**/*.test.ts", ...], and exclude is inherited through extends unless the child overrides it. TypeScript applies exclude as a filter over include, so "include": ["src/tests/**/*.test.ts"] on line 10 is fully cancelled out.

Nothing breaks today because ts-jest reads only compilerOptions from this file and gets its file list from Jest — but the config is self-contradicting: tsc -p tsconfig.test.json would fail with TS18003, and tsserver will no longer associate test files with this project, so describe/expect lose the types: ["jest", "node"] setting in-editor.

Add an override alongside the new compiler options:

"exclude": ["node_modules", "dist"],

},
"exclude": ["node_modules", "dist"],
"include": ["src/tests/**/*.test.ts"]
}
21 changes: 21 additions & 0 deletions packages/precompiles/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2025-2026 Sei Labs

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
7 changes: 5 additions & 2 deletions packages/precompiles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
"version": "2.1.3",
"description": "TypeScript library for EVM interactions on the Sei blockchain",
"main": "./dist/cjs/index.js",
"module": "./dist/esm/index.js",
"module": "./dist/esm/index.mjs",
Comment thread
alexander-sei marked this conversation as resolved.
Comment thread
alexander-sei marked this conversation as resolved.
"types": "./dist/types/index.d.ts",
"sideEffects": false,
"files": [
"dist"
],
"scripts": {
"build": "rimraf dist && pnpm run build:types && pnpm run build:cjs && pnpm run build:esm",
"build:cjs": "tsc --outDir dist/cjs --module commonjs",
"build:esm": "tsc --outDir dist/esm --module esnext",
"build:esm": "esbuild src/index.ts --bundle --format=esm --platform=neutral --packages=external --target=es2020 --outfile=dist/esm/index.mjs",
"build:types": "tsc --project ./tsconfig.declaration.json",
"test": "jest --passWithNoTests"
},
Expand Down
21 changes: 21 additions & 0 deletions packages/registry/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2024-2026 Sei Labs

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
4 changes: 2 additions & 2 deletions packages/registry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.4",
"description": "TypeScript library for Sei chain constants and assets",
"main": "./dist/cjs/src/index.js",
"module": "./dist/esm/src/index.js",
"module": "./dist/esm/src/index.mjs",
Comment thread
alexander-sei marked this conversation as resolved.
"types": "./dist/types/src/index.d.ts",
"sideEffects": false,
"files": [
Expand All @@ -12,7 +12,7 @@
"scripts": {
"build": "rimraf dist && pnpm run build:cjs && pnpm run build:esm && pnpm run build:types",
"build:cjs": "tsc --outDir dist/cjs --module commonjs",
"build:esm": "tsc --outDir dist/esm --module esnext",
"build:esm": "esbuild src/index.ts --bundle --format=esm --platform=neutral --packages=external --target=es2020 --outfile=dist/esm/src/index.mjs",
Comment thread
alexander-sei marked this conversation as resolved.
Comment thread
alexander-sei marked this conversation as resolved.
"build:types": "tsc --project ./tsconfig.declaration.json",
"test": "jest",
"postinstall": "git submodule update --init --recursive"

@seidroid seidroid Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Pre-existing, but squarely in this PR's scope: postinstall ships inside the published tarball, so npm i @sei-js/registry runs git submodule update --init --recursive in the consumer's project. Outside a git repo it errors; inside one it operates on their repo's submodules, not ours. Since this PR is the "publishing hygiene" pass, consider moving submodule bootstrapping to a root-level prepare/dev script (or guarding on !process.env.CI && existsSync('.git')) so it never reaches consumers.

Expand Down
15 changes: 15 additions & 0 deletions packages/sei-global-wallet/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
ISC License

Copyright (c) 2025-2026 Sei Labs

Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.

THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
PERFORMANCE OF THIS SOFTWARE.
2 changes: 1 addition & 1 deletion packages/sei-global-wallet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# @sei-js/sei-global-wallet

[![npm version](https://badge.fury.io/js/@sei-js%2Fsei-global-wallet.svg)](https://badge.fury.io/js/@sei-js%2Fsei-global-wallet)
[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
[![License: ISC](https://img.shields.io/badge/License-ISC-blue.svg)](https://opensource.org/licenses/ISC)
[![TypeScript](https://img.shields.io/badge/TypeScript-007ACC?logo=typescript&logoColor=white)](https://www.typescriptlang.org/)
[![Sei Network](https://img.shields.io/badge/Sei-Network-red)](https://sei.io)

Expand Down
Loading
Loading