Skip to content

Remove redundant libstdc++6 installation #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masih merged 1 commit into from
Aug 4, 2026
Merged

Remove redundant libstdc++6 installation #3847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ RUN --mount=type=cache,target=/go/pkg/mod \
FROM docker.io/ubuntu:24.04@sha256:104ae83764a5119017b8e8d6218fa0832b09df65aae7d5a6de29a85d813da2fb

RUN apt-get update && \
apt-get install -y --no-install-recommends ca-certificates libstdc++6 && \
apt-get install -y --no-install-recommends ca-certificates && \

@seidroid seidroid Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Verified this is safe for the pinned base: the vendored libevmone libs copied in at line 56 require libstdc++.so.6 with at most GLIBCXX_3.4.32 / CXXABI_1.3.9, and ubuntu:24.04 ships libstdc++6 (GCC 13/14, GLIBCXX_3.4.32+) unconditionally because apt itself depends on it.

The caveat is that the dependency is now satisfied only transitively by the base layer rather than declared. If the base is ever swapped for a slim/-minimal/distroless variant (or a digest whose apt no longer pulls libstdc++6), seid will fail at container start with a dlopen/GLIBCXX error that docker build won't catch. Suggest a short comment here recording that libevmone needs the base image's libstdc++6 (>= GLIBCXX_3.4.32), so a future base-image change gets the right prompt.

rm -rf /var/lib/apt/lists/*

COPY --from=builder /go/bin/seid /usr/bin/
Expand Down
Loading