This repository was archived by the owner on Aug 22, 2023. It is now read-only.
MRR is calculated incorrectly#2
Open
gkoberger wants to merge 7 commits into
Open
Conversation
`coupon.valid` only tells you if the coupon could *currently* be added to a new subscription, which means any one-time user coupon would be invalid and not work. Since it's attached, we know it was valid at the time.
Author
|
MRR was being miscalculated due to a number of reasons:
It still doesn't match up with BareMetrics for us (and I'm sure there's a ton of other edge cases), however it's much, much closer. |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a refactor,
amountwasn't changed toamountMrreverywhere.