Document DiffContext and DiffOutput#23
Merged
Merged
Conversation
ninioArtillero
force-pushed
the
ninioArtillero/docs2
branch
3 times, most recently
from
6bd5203 to
9fb23fd
Compare
ninioArtillero
force-pushed
the
ninioArtillero/docs2
branch
from
9fb23fd to
344e6f0
Compare
Contributor
facundominguez
left a comment
facundominguez
left a comment
There was a problem hiding this comment.
Hello! The comments are helpful. I'm contributing some more suggestions.
Co-authored-by: Facundo Domínguez <facundo.dominguez@tweag.io>
Co-authored-by: Facundo Domínguez <facundo.dominguez@tweag.io>
Co-authored-by: Facundo Domínguez <facundo.dominguez@tweag.io>
Co-authored-by: Facundo Domínguez <facundo.dominguez@tweag.io>
ninioArtillero
force-pushed
the
ninioArtillero/docs2
branch
from
0193628 to
8952b71
Compare
Co-authored-by: Facundo Domínguez <facundo.dominguez@tweag.io>
ninioArtillero
force-pushed
the
ninioArtillero/docs2
branch
from
8952b71 to
aee6f8a
Compare
Co-authored-by: Facundo Dominguez <facundo.dominguez@tweag.io>
ninioArtillero
force-pushed
the
ninioArtillero/docs2
branch
from
1fed951 to
24c5baa
Compare
ninioArtillero
changed the title
DiffContext and DiffOutputDiffContext and DiffOutput
Contributor
Author
|
@ddssff We are done updating this PR, so this is ready for review at your earliest convenience. Willing to make/discuss any requested change. |
Member
|
Merging. I love this meticulous and articulate treatment of the algorithm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation the
Data.Algorithm.DiffContextandData.Algorithm.DiffOutput, includingdiffstoaccandcontexttocontextSizevariable name changes to implicitly document their role within the corresponding function bodies.groupByimport fromDiffContext.