#4094 Handle two stage uploads more reliably#5971
Open
akleshchev wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves reliability of two-stage uploads (capability to request a one-time uploader URL, followed by the actual upload) by adding retry logic that re-requests the uploader when the upload stage fails.
Changes:
- Add retry loops (up to 3 total attempts) for two-stage upload flows to re-request one-time uploader URLs on failure.
- Standardize result handling for success/UUID propagation across retries.
- Ensure temporary thumbnail upload files are cleaned up after completion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| indra/newview/llviewerassetupload.cpp | Adds end-to-end retry loop for the two-stage inventory asset upload flow and wires success state through to snapshot notifications. |
| indra/newview/llpanelprofile.cpp | Adds retry loop around the two-stage profile image upload to re-request the uploader cap on upload failure. |
| indra/newview/llfloatersimplesnapshot.cpp | Adds retry loop for thumbnail uploads, fixes coroutine adapter name, propagates resulting asset UUID, and cleans up the temporary image file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2d100c6 to
a511424
Compare
a511424 to
d813582
Compare
maxim-productengine
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some places utilize two-stage upload, where we request an uploader via a permanent capability. uploader is a one-time, time limited capability, if something goes wrong it needs to be rerequested.