Skip to content

#4094 Handle two stage uploads more reliably#5971

Open
akleshchev wants to merge 1 commit into
release/26.3from
andreyk/viewer_4094
Open

#4094 Handle two stage uploads more reliably#5971
akleshchev wants to merge 1 commit into
release/26.3from
andreyk/viewer_4094

Conversation

@akleshchev

Copy link
Copy Markdown
Contributor

Some places utilize two-stage upload, where we request an uploader via a permanent capability. uploader is a one-time, time limited capability, if something goes wrong it needs to be rerequested.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves reliability of two-stage uploads (capability to request a one-time uploader URL, followed by the actual upload) by adding retry logic that re-requests the uploader when the upload stage fails.

Changes:

  • Add retry loops (up to 3 total attempts) for two-stage upload flows to re-request one-time uploader URLs on failure.
  • Standardize result handling for success/UUID propagation across retries.
  • Ensure temporary thumbnail upload files are cleaned up after completion.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
indra/newview/llviewerassetupload.cpp Adds end-to-end retry loop for the two-stage inventory asset upload flow and wires success state through to snapshot notifications.
indra/newview/llpanelprofile.cpp Adds retry loop around the two-stage profile image upload to re-request the uploader cap on upload failure.
indra/newview/llfloatersimplesnapshot.cpp Adds retry loop for thumbnail uploads, fixes coroutine adapter name, propagates resulting asset UUID, and cleans up the temporary image file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llpanelprofile.cpp
Comment thread indra/newview/llfloatersimplesnapshot.cpp

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread indra/newview/llviewerassetupload.cpp Outdated
Comment thread indra/newview/llpanelprofile.cpp Outdated
Comment thread indra/newview/llfloatersimplesnapshot.cpp Outdated
Comment thread indra/newview/llviewerassetupload.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants