p#388 Improve protections and loggiong around shader cache saving#5957
Merged
Conversation
akleshchev
force-pushed
the
andreyk/viewer_p388
branch
from
12b0fd5 to
f477a94
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens shader cache metadata persistence by adding guardrails and additional logging in LLShaderMgr::persistShaderCacheMetadata() to help diagnose cache-save issues.
Changes:
- Validate the shader cache directory before attempting to write metadata.
- Track and log how many cache entries are persisted vs. removed due to LRU expiry.
- Add additional handling around stale shaderbin file removal and metadata serialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_p388
branch
from
f477a94 to
24f7c8f
Compare
maxim-productengine
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic logging for diagnosis and some protections