#5946 Fix excessive 'allowed to terraform' warning#5949
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the land brush terraforming permission check to better respect parcel-level “allow terraform” settings, preventing spurious “not allowed to terraform” notifications while editing terrain.
Changes:
- Update
LLToolBrushLand::canTerraformParcel()to treatLLParcel::getAllowTerraform()as sufficient to allow terraforming (for purposes of suppressing the warning). - Reformat the permission expression for readability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5946
branch
from
0311c65 to
c494760
Compare
maxim-productengine
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canTerraformParcel appears to only be used for gating alertNoTerraformParcel so this should be safe. PF_ALLOW_TERRAFORM flag is deprecated, but there are still sims with this setting and it should be respected.