#5945 cacheOptimize crash handling#5947
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional validation and defensive handling around mesh face unpacking and cacheOptimize() to reduce crash risk from malformed mesh data (notably tangent generation), and improves thread out-of-memory reporting.
Changes:
- Add guard rails in
LLVolume::unpackVolumeFacesInternal()for zero/oversized vertex counts and position-buffer validation. - Add upfront validation in
LLVolumeFace::cacheOptimize()before generating MikkTSpace tangents (pointer/count checks, triangulation, index bounds, normalized-scale sanity). - Include the thread name in the main-thread fatal log for
std::bad_allocinLLThread::tryRun().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| indra/llmath/llvolume.cpp | Adds validation and early-outs while unpacking mesh face data and before tangent generation during cache optimization. |
| indra/llcommon/llthread.cpp | Adjusts OOM handling to log the originating thread name in the main-thread fatal path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5945
branch
from
635ec04 to
fd0ea11
Compare
akleshchev
force-pushed
the
andreyk/viewer_5945
branch
from
fd0ea11 to
9cbb646
Compare
maxim-productengine
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data validation for cacheOptimize.