Prepare for removal of some files#20
Merged
Merged
Conversation
callumlinden
reviewed
Sep 2, 2025
callumlinden
left a comment
callumlinden
left a comment
There was a problem hiding this comment.
Nice - simple, effective. LGTM.
callumlinden
approved these changes
Sep 2, 2025
callumlinden
left a comment
callumlinden
left a comment
There was a problem hiding this comment.
Nice - simple, effective. LGTM.
marchcat
approved these changes
Sep 2, 2025
marchcat
left a comment
marchcat
left a comment
Contributor
There was a problem hiding this comment.
It's good. But maybe we should also add some "File not found" logging here.
akleshchev
force-pushed
the
dullahan_update
branch
from
db84ff3 to
8c5e7d3
Compare
Contributor
Author
Done, thank you. |
marchcat
approved these changes
Sep 2, 2025
akleshchev
force-pushed
the
dullahan_update
branch
from
8c5e7d3 to
a8f68dd
Compare
akleshchev
force-pushed
the
dullahan_update
branch
from
a8f68dd to
5f4a02f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good idea, but it's the simplest approch in circumstances where I can't test this.