Reusable LSL type semantics#164
Open
tapple wants to merge 20 commits into
Open
Conversation
Contributor
|
It looks very well. |
tapple
commented
Jun 27, 2026
Comment on lines
+252
to
+254
| ENUM = "enum", LSLType.INTEGER, "number" | ||
| PARAM = "param", LSLType.LIST, "{number}" | ||
| PARAM_GET = "param-get", LSLType.LIST, "{number}" |
Contributor
Author
There was a problem hiding this comment.
- These are from Associate LSL Functions with Enums #113. I added them only for illustrative purposes. They are unused until one of these PR's is merged and the other rebased.
Contributor
Author
tapple
force-pushed
the
lsl-type-semantics
branch
from
a5cfc53 to
a9cb385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsl_definitions.yamlhas-semanticsfields that tightly associate with the type field. This PR combines them into a shared data structure. This merges how rulesets and functions were handling type semantics into one reusable data structure.I also verified that slua's
gen_primparams_methods.pyrequires no code changes and generates an identicalllprim_set_primitive_params.inldespite the type class changing fromBuilderParamTypetoLSLTypeSemantics.I expect the rulesets code change is the most contentious part of this PR; it is isolated to a single commit just in case: 1a42af5