Add slua_definitions.yaml to generated output#163
Draft
WolfGangS wants to merge 1 commit into
Draft
Conversation
…l_definitions Signed-off-by: Wolfgang <wolfgang@wlf.io>
WolfGangS
commented
Jun 25, 2026
Comment on lines
+264
to
+272
| quaternion_module = slua_definitions.get_module("quaternion") | ||
| rotation_module = SLuaModule( | ||
| name="rotation", | ||
| comment=quaternion_module.comment, | ||
| callable=quaternion_module.callable, | ||
| constants=quaternion_module.constants, | ||
| functions=quaternion_module.functions, | ||
| ) | ||
| slua_definitions.modules.append(rotation_module) |
Contributor
Author
There was a problem hiding this comment.
I suspect this should be moved to the main method that builds up slua_definitions, and not done here, that would also need to be changed in the textmate generator too then.
Contributor
There was a problem hiding this comment.
maybe. only the d.luau generator does anything with the rotation in globalVariables in the raw file. Every other handler does duplicate it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a version of
slua_definitionsto the generated output, that has all the content generated from lsl_defintitions included.Partially resolves #162 Would still need LL implementation to have this file be served in the capabilities instead of the incomplete one.