Add @checked annotations to secondlife.d.luau#125
Open
tapple wants to merge 15 commits into
Open
Conversation
@checked annotations to secondlife.d.luau
cd74b9e to
ef78e00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbeddedBuiltinDefinitions.cpp#122Functions marked
@checkedhas run-time type checks that match the typechecker. These functions report the same errors in--!strictand--!nonstrictmodes.I ran into a luau bug during this PR, and had to add a few ugly workarounds to the generator: luau-lang/luau#2384
I wanted to add @checked to functions in the
llmodule, but, I'm delaying that to a future PR for the following reasons:@checkedin the generator, or in thelsl_definitions.yamlfile@checkeddoes so I can think about it for each ll function. I expect most or allllfunctions will want@checked, but, I need to think about that another timeEmbeddedBuiltinDefinitions.cppsooner rather than later, and this isn't really critical for that