Clean up Visual Studio generator name from cmake <3.0 compatibiliy left overs#54
Merged
Conversation
…ecessary for cmake < 3.1 compatibility but not supported in >= cmake 4.0 Select the full Visual Studio generator name with year which was another cmake < 3.0 compatibility
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This comment was marked as resolved.
This comment was marked as resolved.
brad-linden
approved these changes
Aug 7, 2025
|
Thanks for the PR, RolfKal! Codecov reporting seems to have broken --perhaps the wrong report uploaded as part of a prior run. Let's ignore that for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove platform appendix from Visual Studio generator name, which was necessary for cmake < 3.1 compatibility but not supported in >= cmake 4.0
Select the full Visual Studio generator name with year which was another cmake < 3.0 compatibility