Skip to content

fix: part-named export files and tighter STL tessellation tolerances #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
secersh merged 1 commit into from
Apr 8, 2026
Merged

fix: part-named export files and tighter STL tessellation tolerances #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions .github/workflows/mcad-export.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
-H "Accept: application/json" \
-H "Authorization: Basic $AUTH")

PART_IDS=$(ONSHAPE_PARTS_JSON="$ONSHAPE_PARTS" PART_NUMBERS_LIST="$PART_NUMBERS" python3 -c "
PART_RESOLUTION=$(ONSHAPE_PARTS_JSON="$ONSHAPE_PARTS" PART_NUMBERS_LIST="$PART_NUMBERS" python3 -c "
import json, sys, os
parts = json.loads(os.environ['ONSHAPE_PARTS_JSON'])
part_numbers = os.environ['PART_NUMBERS_LIST'].strip().splitlines()
Expand All @@ -79,18 +79,24 @@ jobs:
print(f'Part number not found in OnShape: {n}', file=sys.stderr)
sys.exit(1)
print(','.join(id_map[n] for n in part_numbers))
print(','.join(part_numbers))
")

if [ $? -ne 0 ]; then
echo "::error:: 🚨 Some part numbers from ${{ inputs.parts_file }} were not found in OnShape. Check that part numbers match the partNumber property set in OnShape (right-click → Properties)."
exit 1
fi

PART_IDS=$(echo "$PART_RESOLUTION" | sed -n '1p')
PART_NAMES=$(echo "$PART_RESOLUTION" | sed -n '2p')

echo "part_ids=$PART_IDS" >> $GITHUB_OUTPUT
echo "part_names=$PART_NAMES" >> $GITHUB_OUTPUT

- name: Export STEP files
env:
PART_IDS: ${{ steps.read_parts.outputs.part_ids }}
PART_NAMES: ${{ steps.read_parts.outputs.part_names }}
run: |
echo "::notice:: 📐 Exporting STEP files from OnShape (${{ inputs.artifact_suffix }})..."

Expand Down Expand Up @@ -152,14 +158,16 @@ jobs:
exit 1
fi

IFS=',' read -ra NAMES <<< "$PART_NAMES"
INDEX=0
for FID in $FIDS; do
echo "::notice:: 📥 Downloading STEP file with ID: $FID"
NAME="${NAMES[$INDEX]}"
echo "::notice:: 📥 Downloading STEP file with ID: $FID (part: $NAME)"
curl -s -X 'GET' \
"https://cad.onshape.com/api/v10/documents/d/${{ vars.DID }}/externaldata/$FID" \
-H "Accept: application/octet-stream" \
-H "Authorization: Basic $AUTH" \
-o "manufacturing/step/step-${{ inputs.artifact_suffix }}-${INDEX}.zip"
-o "manufacturing/step/${NAME}.zip"

if [ $? -ne 0 ]; then
echo "::error:: 🚨 Failed to download STEP file with ID: $FID"
Expand All @@ -172,14 +180,15 @@ jobs:
- name: Export STL files
env:
PART_IDS: ${{ steps.read_parts.outputs.part_ids }}
PART_NAMES: ${{ steps.read_parts.outputs.part_names }}
run: |
echo "::notice:: 🖨️ Exporting STL files from OnShape (${{ inputs.artifact_suffix }})..."

mkdir -p manufacturing/stl

JSON_BODY=$(jq -n \
--arg partIds "$PART_IDS" \
'{storeInDocument:false,partIds:$partIds,formatName:"STL",grouping:false,specifyUnits:true,unit:"MILLIMETER",scale:"1.0",angularTolerance:0.1,chordTolerance:0.05}')
'{storeInDocument:false,partIds:$partIds,formatName:"STL",grouping:false,specifyUnits:true,unit:"MILLIMETER",scale:"1.0",angularTolerance:0.05,chordTolerance:0.01}')

SUBMIT_RES=$(curl -s -X 'POST' \
"https://cad.onshape.com/api/v10/partstudios/d/${{ vars.DID }}/w/${{ vars.WVMID }}/e/${{ vars.EID }}/translations?configuration=$ENCODED_CONFIG" \
Expand Down Expand Up @@ -233,14 +242,16 @@ jobs:
exit 1
fi

IFS=',' read -ra NAMES <<< "$PART_NAMES"
INDEX=0
for FID in $FIDS; do
echo "::notice:: 📥 Downloading STL file with ID: $FID"
NAME="${NAMES[$INDEX]}"
echo "::notice:: 📥 Downloading STL file with ID: $FID (part: $NAME)"
curl -s -X 'GET' \
"https://cad.onshape.com/api/v10/documents/d/${{ vars.DID }}/externaldata/$FID" \
-H "Accept: application/octet-stream" \
-H "Authorization: Basic $AUTH" \
-o "manufacturing/stl/stl-${{ inputs.artifact_suffix }}-${INDEX}.zip"
-o "manufacturing/stl/${NAME}.zip"

if [ $? -ne 0 ]; then
echo "::error:: 🚨 Failed to download STL file with ID: $FID"
Expand Down