Skip to content

GH-119: Moved legacy code in dedicated folder#120

Closed
ppaulweber wants to merge 5 commits intomasterfrom
task/119_update_repo_and_website
Closed

GH-119: Moved legacy code in dedicated folder#120
ppaulweber wants to merge 5 commits intomasterfrom
task/119_update_repo_and_website

Conversation

@ppaulweber
Copy link
Copy Markdown
Contributor

@ppaulweber ppaulweber commented Nov 22, 2025

This PR introduces the following changes:

@ppaulweber ppaulweber self-assigned this Nov 22, 2025
@ppaulweber ppaulweber force-pushed the task/119_update_repo_and_website branch from 4172380 to 745737f Compare November 22, 2025 21:22
@ppaulweber ppaulweber changed the title 119: Moved legacy code in dedicated folder GH-119: Moved legacy code in dedicated folder Nov 22, 2025
@ppaulweber ppaulweber changed the title GH-119: Moved legacy code in dedicated folder 119: Moved legacy code in dedicated folder Feb 21, 2026
@ppaulweber ppaulweber marked this pull request as ready for review February 21, 2026 09:53
@ppaulweber ppaulweber requested a review from Copilot February 21, 2026 09:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the repository by relocating legacy/deprecated project components into a dedicated legacy area, while also updating licensing and GitHub Pages legal/footer content.

Changes:

  • Repointed git submodules to live under .github/legacy/.
  • Updated copyright years in LICENSE and GitHub Pages content.
  • Removed several legacy-era helper/config/build files from the repository root.

Reviewed changes

Copilot reviewed 12 out of 42 changed files in this pull request and generated no comments.

Show a summary per file
File Description
var/casm-test Removed legacy test wrapper script.
var/casm-benchmark Removed legacy benchmark wrapper script.
var/README.org Removed legacy folder README.
ext/README.org Removed legacy folder README.
app/README.org Removed legacy folder README.
LICENSE Updated copyright year range.
Doxyfile Removed legacy Doxygen configuration.
CMakeLists.txt Removed legacy CMake build entrypoint.
.ycm_extra_conf.py Removed legacy editor tooling configuration.
.gitmodules Updated submodule paths to .github/legacy/*.
.github/pages/content/site/notice.md Updated copyright year and refined legacy licensing wording.
.github/pages/config.toml Updated footer year for GitHub Pages site.
.clang-format Removed legacy formatting configuration.
Comments suppressed due to low confidence (2)

.gitmodules:1

  • The submodule section names (e.g. "app/casmc") no longer match their new path values under .github/legacy/*, which makes the configuration harder to reason about and can be confusing when inspecting submodule.<name>.* settings. Consider renaming the submodule names to align with the new paths (e.g. "legacy/casmc" or ".github/legacy/casmc") for consistency/readability.
    .github/pages/config.toml:1
  • This hard-codes the year in the site footer, which will require a manual update every year. If your Pages build uses templating for the footer, consider deriving the current year in the template instead of storing a fixed year string in config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ppaulweber ppaulweber changed the title 119: Moved legacy code in dedicated folder GH-119: Moved legacy code in dedicated folder Feb 21, 2026
@ppaulweber ppaulweber force-pushed the task/119_update_repo_and_website branch from df30d8e to 212b194 Compare February 21, 2026 10:09
Copilot AI review requested due to automatic review settings February 21, 2026 10:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 44 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (5)

.github/workflows/github-autolink-pr-to-issues.yaml:1

  • The failure messages have broken formatting due to missing \n and a missing string concatenation between the “Format” and “Example” lines in the PR title validation. Add explicit newlines (and ensure the strings are concatenated) so the output is readable in the Actions log.
    .github/workflows/github-autolink-pr-to-issues.yaml:1
  • The failure messages have broken formatting due to missing \n and a missing string concatenation between the “Format” and “Example” lines in the PR title validation. Add explicit newlines (and ensure the strings are concatenated) so the output is readable in the Actions log.
    .github/workflows/github-autolink-pr-to-issues.yaml:1
  • This workflow runs on edited and synchronize, but it always creates a new PR comment on each successful run. This will spam PR threads over time; instead, look up an existing bot comment (e.g., by a stable marker in the body) and update it, or only comment when the PR is first opened and use logs/check annotations for subsequent runs.
    .github/workflows/github-autolink-pr-to-issues.yaml:1
  • This workflow runs on edited and synchronize, but it always creates a new PR comment on each successful run. This will spam PR threads over time; instead, look up an existing bot comment (e.g., by a stable marker in the body) and update it, or only comment when the PR is first opened and use logs/check annotations for subsequent runs.
    .github/workflows/github-autolink-pr-to-issues.yaml:1
  • The workflow performs issues.createComment, but it doesn’t declare explicit permissions. Add minimal required permissions (e.g., issues: write and pull-requests: read) to avoid relying on repository defaults, and consider skipping the “create comment” step for forked PRs (where the token is typically read-only) to prevent avoidable failures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ppaulweber ppaulweber closed this Feb 21, 2026
@ppaulweber ppaulweber deleted the task/119_update_repo_and_website branch February 21, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants