GH-119: Moved legacy code in dedicated folder#120
Closed
ppaulweber wants to merge 5 commits intomasterfrom
Closed
Conversation
4172380 to
745737f
Compare
There was a problem hiding this comment.
Pull request overview
This PR restructures the repository by relocating legacy/deprecated project components into a dedicated legacy area, while also updating licensing and GitHub Pages legal/footer content.
Changes:
- Repointed git submodules to live under
.github/legacy/. - Updated copyright years in
LICENSEand GitHub Pages content. - Removed several legacy-era helper/config/build files from the repository root.
Reviewed changes
Copilot reviewed 12 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| var/casm-test | Removed legacy test wrapper script. |
| var/casm-benchmark | Removed legacy benchmark wrapper script. |
| var/README.org | Removed legacy folder README. |
| ext/README.org | Removed legacy folder README. |
| app/README.org | Removed legacy folder README. |
| LICENSE | Updated copyright year range. |
| Doxyfile | Removed legacy Doxygen configuration. |
| CMakeLists.txt | Removed legacy CMake build entrypoint. |
| .ycm_extra_conf.py | Removed legacy editor tooling configuration. |
| .gitmodules | Updated submodule paths to .github/legacy/*. |
| .github/pages/content/site/notice.md | Updated copyright year and refined legacy licensing wording. |
| .github/pages/config.toml | Updated footer year for GitHub Pages site. |
| .clang-format | Removed legacy formatting configuration. |
Comments suppressed due to low confidence (2)
.gitmodules:1
- The submodule section names (e.g.
"app/casmc") no longer match their newpathvalues under.github/legacy/*, which makes the configuration harder to reason about and can be confusing when inspectingsubmodule.<name>.*settings. Consider renaming the submodule names to align with the new paths (e.g."legacy/casmc"or".github/legacy/casmc") for consistency/readability.
.github/pages/config.toml:1 - This hard-codes the year in the site footer, which will require a manual update every year. If your Pages build uses templating for the footer, consider deriving the current year in the template instead of storing a fixed year string in config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
df30d8e to
212b194
Compare
…d autolink GH issue with PR
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 44 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (5)
.github/workflows/github-autolink-pr-to-issues.yaml:1
- The failure messages have broken formatting due to missing
\nand a missing string concatenation between the “Format” and “Example” lines in the PR title validation. Add explicit newlines (and ensure the strings are concatenated) so the output is readable in the Actions log.
.github/workflows/github-autolink-pr-to-issues.yaml:1 - The failure messages have broken formatting due to missing
\nand a missing string concatenation between the “Format” and “Example” lines in the PR title validation. Add explicit newlines (and ensure the strings are concatenated) so the output is readable in the Actions log.
.github/workflows/github-autolink-pr-to-issues.yaml:1 - This workflow runs on
editedandsynchronize, but it always creates a new PR comment on each successful run. This will spam PR threads over time; instead, look up an existing bot comment (e.g., by a stable marker in the body) and update it, or only comment when the PR is first opened and use logs/check annotations for subsequent runs.
.github/workflows/github-autolink-pr-to-issues.yaml:1 - This workflow runs on
editedandsynchronize, but it always creates a new PR comment on each successful run. This will spam PR threads over time; instead, look up an existing bot comment (e.g., by a stable marker in the body) and update it, or only comment when the PR is first opened and use logs/check annotations for subsequent runs.
.github/workflows/github-autolink-pr-to-issues.yaml:1 - The workflow performs
issues.createComment, but it doesn’t declare explicitpermissions. Add minimal required permissions (e.g.,issues: writeandpull-requests: read) to avoid relying on repository defaults, and consider skipping the “create comment” step for forked PRs (where the token is typically read-only) to prevent avoidable failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
.github/legacy/folderLICENSEinformation