Skip to content

[WJ-1041] Add syntax blocks for media #108

Merged
emmiegit merged 18 commits intoscpwiki:mainfrom
jsthope:media_blocks_clean
Mar 29, 2026
Merged

[WJ-1041] Add syntax blocks for media #108
emmiegit merged 18 commits intoscpwiki:mainfrom
jsthope:media_blocks_clean

Conversation

@jsthope
Copy link
Copy Markdown
Contributor

@jsthope jsthope commented Mar 29, 2026

see WJ-1041

This PR will precede a likely future Wikijump PR on implementing HTTP support for Range requests in wws.

@jsthope jsthope requested a review from emmiegit as a code owner March 29, 2026 16:42
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

❌ Patch coverage is 60.40268% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.87%. Comparing base (67866ef) to head (481c109).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/parsing/rule/impls/block/blocks/media.rs 53.84% 24 Missing ⚠️
src/tree/element/object.rs 16.66% 10 Missing ⚠️
src/render/html/element/audio.rs 74.19% 8 Missing ⚠️
src/render/html/element/video.rs 75.75% 8 Missing ⚠️
src/test/prop.rs 0.00% 4 Missing ⚠️
src/render/handle.rs 66.66% 3 Missing ⚠️
src/tree/file_source.rs 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   67.10%   66.87%   -0.23%     
==========================================
  Files         222      226       +4     
  Lines        6588     6742     +154     
==========================================
+ Hits         4421     4509      +88     
- Misses       2167     2233      +66     
Flag Coverage Δ *Carryforward flag
ftml 64.55% <ø> (-0.01%) ⬇️ Carriedforward from 67866ef

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/parsing/rule/impls/block/blocks/image.rs 84.61% <100.00%> (ø)
src/parsing/rule/impls/block/blocks/mod.rs 83.33% <ø> (ø)
src/parsing/rule/impls/block/mapping.rs 93.33% <ø> (ø)
src/render/html/element/image.rs 96.15% <100.00%> (ø)
src/render/html/element/mod.rs 56.06% <100.00%> (+1.37%) ⬆️
src/render/text/elements.rs 27.65% <ø> (ø)
src/tree/mod.rs 100.00% <ø> (ø)
src/tree/file_source.rs 52.00% <50.00%> (ø)
src/render/handle.rs 70.00% <66.66%> (-0.38%) ⬇️
src/test/prop.rs 0.00% <0.00%> (ø)
... and 4 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small suggestions:

@emmiegit
Copy link
Copy Markdown
Member

Please rebase and bump the crate version: 1.40.0 -> 1.41.0

@jsthope jsthope self-assigned this Mar 29, 2026
@jsthope jsthope force-pushed the media_blocks_clean branch from 4f185b3 to 72df39c Compare March 29, 2026 18:50
Copy link
Copy Markdown
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jsthope and others added 2 commits March 29, 2026 21:33
Co-authored-by: Emmie <emmie.maeda@gmail.com>
@emmiegit emmiegit merged commit 4a4242e into scpwiki:main Mar 29, 2026
6 checks passed
@jsthope jsthope deleted the media_blocks_clean branch March 29, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants