Skip to content

add wikidot |agohover format tag for DOM compatibility#107

Merged
emmiegit merged 8 commits intoscpwiki:mainfrom
jsthope:main
Mar 29, 2026
Merged

add wikidot |agohover format tag for DOM compatibility#107
emmiegit merged 8 commits intoscpwiki:mainfrom
jsthope:main

Conversation

@jsthope
Copy link
Copy Markdown
Contributor

@jsthope jsthope commented Mar 27, 2026

Last addition before the compatibility of [[date]] with the Wikijump DOM is complete (WJ-1328).
I've assumed here that for Wikijump, |agohover is ignored because the hover tag is already set to true for it.

@jsthope jsthope requested a review from emmiegit as a code owner March 27, 2026 15:41
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.09%. Comparing base (594469e) to head (509e327).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/parsing/rule/impls/block/blocks/date.rs 63.63% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   67.09%   67.09%   -0.01%     
==========================================
  Files         222      222              
  Lines        6570     6588      +18     
==========================================
+ Hits         4408     4420      +12     
- Misses       2162     2168       +6     
Flag Coverage Δ *Carryforward flag
ftml 64.55% <ø> (+0.02%) ⬆️ Carriedforward from b7f71dc

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/render/html/element/date.rs 100.00% <100.00%> (ø)
src/parsing/rule/impls/block/blocks/date.rs 75.30% <63.63%> (-2.47%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/render/html/element/date.rs Outdated
Comment thread src/render/html/element/date.rs Outdated
Comment thread src/render/html/element/date.rs Outdated
Comment thread src/render/html/element/date.rs
@jsthope jsthope requested a review from emmiegit March 27, 2026 21:27
@emmiegit emmiegit merged commit e05855b into scpwiki:main Mar 29, 2026
8 checks passed
emmiegit added a commit that referenced this pull request Mar 29, 2026
Changes in #107 add support for "|agohover" in date formatting.
@jsthope jsthope self-assigned this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants