Add option to follow 301 and 302 redirection#93
Add option to follow 301 and 302 redirection#93yujincheng08 wants to merge 1 commit intoscottlamb:mainfrom
Conversation
|
Hi, RTSP follows HTTP which also sends Authorization header to redirected target. |
ef4ca8c to
8ffe41c
Compare
|
Change the option to |
|
@scottlamb Gentle ping |
2 similar comments
|
@scottlamb Gentle ping |
|
@scottlamb Gentle ping |
|
Hey, I know you've been waiting a long time on this. I'm uncomfortable though about the security implications of sending the credentials to another host.
Can you point me at where the spec mandates clients behave in that way? I can't find it, and I've read through the HTTP/1.1 spec (and specifically several versions of Here's a stackoverflow thread on the subject, fwiw, and it suggests other clients have made the choice to remove credentials on redirect. In your use case, are redirects happening to a different (scheme, host, port)? or is only the path changing? I'd be less concerned about...
trait CredentialStore {
fn get_credentials(url: &Url) -> Box<Future<Item = Result<Credentials, BoxError>>>
} |
|
Might be better to just expose the header (or all the headers) in |
Fix #92