fix: connection failed with some cctv#106
Open
giangndm wants to merge 2 commits intoscottlamb:mainfrom
Open
Conversation
scottlamb
reviewed
Sep 23, 2025
| stream_id: usize, | ||
| data: Bytes, | ||
| ) -> Result<Option<PacketItem>, Error> { | ||
| if !(data.len() >= 12 && data[0] > 127 && data[0] < 192) { |
Owner
There was a problem hiding this comment.
This is bailing early to avoid the too short and must be version 2 checks in RawPacket::new, right? The former doesn't happen with the test packet in the src/rtp.rs's dahua test, and I think the latter shouldn't happen with any current RTCP packets—they have a similar version field in a similar place.
Do you have some example data that shows the problem? I think we at least should have a unit test of this, and we may be able to improve on the solution.
scottlamb
added
the
need-input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix some issues with some cctv providers: