Skip to content

Add confirmation dialogs for pane and side-tab actions - #17

Merged
scokeepa merged 1 commit into
masterfrom
chore/verify-cli-compat-smoke-coverage
Apr 14, 2026
Merged

Add confirmation dialogs for pane and side-tab actions#17
scokeepa merged 1 commit into
masterfrom
chore/verify-cli-compat-smoke-coverage

Conversation

@scokeepa

Copy link
Copy Markdown
Owner

Summary

  • Add confirmation dialogs before closing a pane, closing a side tab(surface), and resetting a pane session.
  • Apply the guard at ViewModel level so toolbar/context-menu/shortcut paths all share the same confirmation behavior.
  • Add Korean/Chinese localization entries for the new confirmation titles and messages.

Test plan

  • dotnet build src/Cmux/Cmux.csproj -c Debug
  • Manual check: pane close asks confirmation
  • Manual check: surface(side tab) close asks confirmation
  • Manual check: pane session reset asks confirmation

This requires explicit user confirmation before closing panes, closing side tabs, and resetting pane sessions, and adds localized confirmation text for Korean and Chinese.
@scokeepa
scokeepa merged commit 87ac70c into master Apr 14, 2026
3 checks passed
@scokeepa
scokeepa deleted the chore/verify-cli-compat-smoke-coverage branch April 14, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant