Repository navigation
feat: speedup lheh5/hdf5 read performance - #425
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 962 972 +10
=========================================
+ Hits 962 972 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🏎️ Benchmark Comparison |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical path and batching issues, plus empty-dataset and API compatibility concerns, remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Improves LHEH5/HDF5 read performance through batched data access and adds benchmarks and documentation.
Changes:
- Batch event and particle reads.
- Add NumPy dependency and reader test updates.
- Add I/O benchmarks and format-comparison documentation.
| File | Summary |
|---|---|
tests/test_lheh5_reader.py |
Updates reader tests for particle-column handling. |
src/pylhe/lheh5.py |
Implements batched reads; needs batch_size, empty-dataset, and API compatibility fixes. |
pyproject.toml |
Adds NumPy dependency. |
docs/source/index.rst |
Includes comparison documentation. |
docs/source/examples/benchmark_io_formats.py |
Adds benchmark utility; documented commands reference the wrong path. |
docs/source/comparison.rst |
Documents benchmark results. |
benchmarks/test_lheh5_io_bench.py |
Adds HDF5 I/O benchmarks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated example commands to reference the correct path for benchmark_io_formats.py. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
eduardo-rodrigues
left a comment
There was a problem hiding this comment.
This all looks great!
Note that I did not review the script docs/source/examples/benchmark_io_formats.py.
Co-authored-by: Eduardo Rodrigues <eduardo.rodrigues@cern.ch>

Closes: #423
Old results: