Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 960 962 +2
=========================================
+ Hits 960 962 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🏎️ Benchmark Comparison |
Co-authored-by: Eduardo Rodrigues <eduardo.rodrigues@cern.ch>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the public dataclass field-order compatibility issue and add coverage for non-default compression levels.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds README rationale and configurable gzip compression levels for LHE XML output.
Changes:
- Adds a “Why pylhe?” section to the README.
- Adds
compressleveltoLHEXMLFormat. - Clarifies HDF5 gzip compression settings.
| File | Summary |
|---|---|
src/pylhe/__init__.py |
Critical: preserve positional dataclass compatibility. Moderate: add a regression test for non-default compression levels. |
README.md |
Documents project rationale and supported capabilities. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eduardo-rodrigues
left a comment
There was a problem hiding this comment.
Looks good, many thanks.


Part-of: #409 (the edit of statement of need missing in the docs)