Repository navigation
fix: normalize vectorized histogram bin indices - #1210
Merged
Merged
Conversation
Name the axis in the out-of-range error, wrap negatives in place on one copy, and test non-integer arrays, setitem, and multi-axis cases. Assisted-by: ClaudeCode:claude-opus-5-5
Member
|
Pushed a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy array indices can select the wrong bins. For example,
h[np.array([-1])]reads or overwrites the underflow bin whileh[-1]selects the last regular bin. Out-of-range array indices can also silently select flow bins.This checks bounds and normalizes negative indices before adding the flow offset. Converting to
intpalso prevents narrow integer arrays from wrapping during that offset. Boolean arrays now raiseIndexError, consistent with this API's documented integer-array input.Extended the existing flow-offset test. It fails on the original code and passes with the fix. The full suite passes with 1300 passed and 4 expected failures, and all applicable prek hooks pass on the changed files. Independent review checked get/set, category axes, storage types and mixed indexing.
Tested on macOS arm64, Python 3.12 and NumPy 2.5.5. The minimum NumPy version was not tested locally.
Prepared with AI assistance.