Conversation
Split snes and ksp options in all tests.
…tly on each process. The placeholder creation then deadlocked as Function initialization is a collective operation. Add ufl_id to Function and Constant to have something to sort them by. Another improvement is to use direct solvers in the test (not relying on petsc defaults) and setting adjoint and tlm options as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-fixes
Bug-fixes
Use correct output type from re-computation (dolfinx_adjoint.Function rather than dolfinx.fem.Function). This means no usage of dolfinx.fem.Function.copy())