[WIP] Trying to remove custom qt patch dependency#2
Open
Hritik14 wants to merge 1 commit intoschultetwin1:masterfrom
Open
[WIP] Trying to remove custom qt patch dependency#2Hritik14 wants to merge 1 commit intoschultetwin1:masterfrom
Hritik14 wants to merge 1 commit intoschultetwin1:masterfrom
Conversation
Hi, I really liked the idea of the project. I thought maybe these changes could achieve what the patch is trying to. I'm not completely sure though, there appears one more permission issue that the patch is addressing which this commit is not. Please have a look at the changes, I'm completely new to QtBLE programming so there might be some mess I made. But if not, if I'm on the correct track, I'd really like to proceed with the changes and address everything that the patch addreseses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I really liked the idea of the project. I thought maybe these
changes could achieve what the patch is trying to. I'm not completely
sure though, there appears one more permission issue that the patch is
addressing which this commit is not.
Please have a look at the changes, I'm completely new to QtBLE programming
so there might be some mess I made. But if not, if I'm on the correct
track, I'd really like to proceed with the changes and address
everything that the patch addreseses.