Manage CRR endpoints without explicit port#2721
Open
maeldonn wants to merge 1 commit intodevelopment/9.2from
Open
Manage CRR endpoints without explicit port#2721maeldonn wants to merge 1 commit intodevelopment/9.2from
maeldonn wants to merge 1 commit intodevelopment/9.2from
Conversation
Contributor
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 6 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.2 #2721 +/- ##
===================================================
- Coverage 74.94% 74.70% -0.25%
===================================================
Files 201 201
Lines 13517 13522 +5
===================================================
- Hits 10130 10101 -29
- Misses 3377 3411 +34
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
maeldonn
requested review from
SylvainSenechal,
benzekrimaha,
delthas and
francoisferrand
maeldonn
force-pushed
the
bugfix/BB-746/crr-endpoint
branch
2 times, most recently
from
3300ae7 to
e9586e5
Compare
SylvainSenechal
approved these changes
Feb 25, 2026
| { "site": "https-site", "servers": ["s3.example.com"] }, | ||
| { "site": "http-site", "servers": ["s3.example.com"] }, | ||
| { "site": "explicit-port-site", "servers": ["s3.example.com:8443"] }, | ||
| { "site": "aws-site", "type": "aws_s3" } |
Contributor
There was a problem hiding this comment.
missing case(s) where servers is not an array
Author
There was a problem hiding this comment.
Servers cannot be a string. There is a validator for this: https://github.com/scality/backbeat/blob/development/9.3/lib/config/configItems.joi.js#L22
maeldonn
force-pushed
the
bugfix/BB-746/crr-endpoint
branch
from
7b6addd to
d1e5586
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: BB-746
This is the same PR as #2718 but with a different branch name.