removed cypress ui tests, removed npm and use yarn for zenko tests, updated e2e zenko tests dockerfile#2334
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
324949f to
b8c2af6
Compare
b8c2af6 to
8198a3d
Compare
There was a problem hiding this comment.
yarn and npm were co existing, I removed npm, but running yarn install triggered some versioning issues with dependencies unavailable in Node 18. Ended up updating this dockerfile, node 22 isn't really the latest version, but it's the one we use with ctst, anyways this dockerfile should hopefully be removed in the future
maeldonn
left a comment
There was a problem hiding this comment.
LGTM, it would be good to split into two commits (one for cypress and another one for yarn)
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZENKO-5200. Goodbye sylvainsenechal. |
Issue: ZENKO-5200