Skip to content

removed cypress ui tests, removed npm and use yarn for zenko tests, updated e2e zenko tests dockerfile#2334

Merged
bert-e merged 1 commit intodevelopment/2.14from
improvement/ZENKO-5200
Feb 25, 2026
Merged

removed cypress ui tests, removed npm and use yarn for zenko tests, updated e2e zenko tests dockerfile#2334
bert-e merged 1 commit intodevelopment/2.14from
improvement/ZENKO-5200

Conversation

@SylvainSenechal
Copy link
Contributor

Issue: ZENKO-5200

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2026

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5200 branch 6 times, most recently from 324949f to b8c2af6 Compare February 24, 2026 09:46
@SylvainSenechal SylvainSenechal changed the base branch from development/2.14 to improvement/ZENKO-5181 February 24, 2026 09:48
@SylvainSenechal SylvainSenechal changed the title removed cypress ui tests, useless docker entrypoint, removed npm and use yarn for zenko tests removed cypress ui tests, removed npm and use yarn for zenko tests, updated e2e zenko tests dockerfile Feb 24, 2026
@scality scality deleted a comment from bert-e Feb 24, 2026
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn and npm were co existing, I removed npm, but running yarn install triggered some versioning issues with dependencies unavailable in Node 18. Ended up updating this dockerfile, node 22 isn't really the latest version, but it's the one we use with ctst, anyways this dockerfile should hopefully be removed in the future

@SylvainSenechal SylvainSenechal marked this pull request as ready for review February 24, 2026 10:00
@SylvainSenechal SylvainSenechal requested review from a team, delthas and maeldonn February 24, 2026 10:00
Copy link

@maeldonn maeldonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be good to split into two commits (one for cypress and another one for yarn)

Base automatically changed from improvement/ZENKO-5181 to development/2.14 February 25, 2026 19:03
@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@SylvainSenechal
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.14

The following branches will NOT be impacted:

  • development/2.10
  • development/2.11
  • development/2.12
  • development/2.13
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.14

The following branches have NOT changed:

  • development/2.10
  • development/2.11
  • development/2.12
  • development/2.13
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ZENKO-5200.

Goodbye sylvainsenechal.

@bert-e bert-e merged commit 5143ca6 into development/2.14 Feb 25, 2026
27 of 28 checks passed
@bert-e bert-e deleted the improvement/ZENKO-5200 branch February 25, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants