Fix: replace request-micro with dropin-request in maserver#68
Open
steko13 wants to merge 1 commit intosarnau:masterfrom
Open
Fix: replace request-micro with dropin-request in maserver#68steko13 wants to merge 1 commit intosarnau:masterfrom
steko13 wants to merge 1 commit intosarnau:masterfrom
Conversation
cloud forward doesn#t work with request-micro package (apparantly different command syntax), so use dropin-request instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sarnau,
I've noticed that request-micro is causing issues and it is not working reliably in the maserver component on my end. Problems appear when using cloud forwarding (as 'request-micro' is only used in that scenario). I've found 'dropin-request' working fine without any additional code changes.
Changes:
This should fix the request issues while keeping the existing logic intact.
Best regards