storage: netapp-monitoring chart#11869
Conversation
This reverts commit 2de2547.
RockSolidScripts
changed the title
viennaa
left a comment
viennaa
left a comment
There was a problem hiding this comment.
Thanks for tackling this topic. Couple of nits are inline which need to be addressed for this first review.
Most important one is the location of this chart, we might need to move it to greenhouse-extensions but I would like to clarify this. If needed, we can take this offline.
| - host: {{ .Host }} | ||
| - DC: {{ .Facility }} | ||
| - Service: {{ .Service }} | ||
| - lob: `}}{{ .Values.netappsd.lob }} |
There was a problem hiding this comment.
declare in values.yaml, give it a default
There was a problem hiding this comment.
These labels come from the service discovery 'worker' container. The worker container takes this as a template and render it with the data from the service discovery logic.
ref:
- name: worker
image: "{{ .Values.netappsd.image.repository }}:{{ .Values.netappsd.image.tag }}"
imagePullPolicy: {{ .Values.netappsd.image.pullPolicy | default "IfNotPresent" }}
command: ["/netappsd", "worker"]
args:
- --master-url
- http://{{ include "netapp-monitoring.fullname" . }}-{{ $appName }}-master.{{ .Release.Namespace }}.svc:{{ .Values.netappsd.ports.metrics }}
- --listen-addr
- :8080
- --template-file
- /app/harvest.yaml.tpl
- --output-file
- /app/shared/harvest.yamldefaults are set for the values referenced via helm chart.
There was a problem hiding this comment.
mh I still can't spot .Values.netappsd.lob
| namespace: {{ .Release.Namespace }} | ||
| type: Opaque | ||
| data: | ||
| {{ .Values.netappsd.credentials_secret }}.yml: {{ include "netapp-monitoring.credentials-entry" . | b64enc }} |
| {{- range $.Values.finalizers }} | ||
| - {{ . | quote }} | ||
| {{- end }} | ||
| name: {{ .Values.netappsd.credentials_secret }} |
There was a problem hiding this comment.
add required to not let it fail
| mountPath: {{ .Values.netappsd.credentials_file }} | ||
| subPath: {{ .Values.netappsd.credentials_secret }}.yml |
| port: 13000 | ||
| targetPort: 13000 |
| Create the name of the service account to use | ||
| */}} | ||
| {{- define "netapp-monitoring.serviceAccountName" -}} | ||
| {{- if .Values.serviceAccount.create }} |
There was a problem hiding this comment.
should this be .Values.netappsd.serviceAccount? Still the create option is missing.
There was a problem hiding this comment.
good catch. thanks
fixed.
|
Closing this PR as it is moved - cloudoperators/greenhouse-extensions#1728 |
2 participants
Helm for netapp-monitoring harvest
This chart includes service dicsovery from netbox - netappsd
Test Results in our internal
qa-de-1cluster with service discovery for SCI devices: