feat: create ServerReadinessCheck objects from Netbox interface data#167
Open
xkonni wants to merge 1 commit into
Open
feat: create ServerReadinessCheck objects from Netbox interface data#167xkonni wants to merge 1 commit into
xkonni wants to merge 1 commit into
Conversation
Adds opt-in support for creating ServerReadinessCheck objects (from metal-maintenance-operator) per device reconciled by IronCoreReconciler. When --readiness-checks=network is set, argora fetches interface data from Netbox for each active device and creates a ServerReadinessCheck in the configured namespace (--readiness-check-namespace) with the device's MAC addresses and expected carrierStatus. MMO then validates the actual server network interfaces against this spec and gates server availability via a NoBind taint until the wiring is verified. Supersedes PR #145 (ServerNetworkConfig).
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--readiness-checks=networkflag (opt-in, disabled by default) to enableServerReadinessCheckcreation--readiness-check-namespaceflag to configure where objects are created (default:metal-maintenance-operator-system)ServerReadinessCheckwith MAC addresses and expectedcarrierStatus: upunstructured.Unstructured— no dependency on metal-maintenance-operator moduleServerReadinessCheckis owned by metal-maintenance-operator. MMO validates actual vs expected wiring and sets aNetworkReadycondition on the server. Metal-operator'sServerReadinessRuleServerReconcilerthen applies/removes aNoBindtaint automatically.Supersedes and closes #145 (ServerNetworkConfig — wrong type, build failures).
Test plan
make tilt-upin baremetal-workspaceNetworkReadycondition, metal-operator applies/removesNoBindtaint based on expected vs actual interface data--readiness-checks=network --readiness-check-namespace=metal-serversServerReadinessCheckobjects created inmetal-serversnamespace after reconcilespec.network.interfacespopulated with correct MACs from NetboxNetworkReadycondition on serversNoBindtaint when interfaces match, taint present when they don't--readiness-checksis not set