test: add process exit and safe chaining to notification smoke tests#231
Open
jadonamite wants to merge 1 commit into
Open
test: add process exit and safe chaining to notification smoke tests#231jadonamite wants to merge 1 commit into
jadonamite wants to merge 1 commit into
Conversation
Updates the custom NotificationSystemTest runner to explicitly call process.exit(0) upon successful completion, preventing the script from hanging indefinitely due to open service connections in the event loop. Adds optional chaining to assertions to prevent uncaught TypeErrors if the manager or service methods return null or undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the custom NotificationSystemTest runner to explicitly call process.exit(0) upon successful completion, preventing the script from hanging indefinitely due to open service connections in the event loop. Adds optional chaining to assertions to prevent uncaught TypeErrors if the manager or service methods return null or undefined.