Skip to content

fix: remove justify from alignment options - #3286

Merged
somerandomdude merged 3 commits into
v5-alphafrom
fix-remove-justify-alignment
Oct 30, 2026
Merged

somerandomdude merged 3 commits into
v5-alphafrom
fix-remove-justify-alignment

Conversation

@somerandomdude

@somerandomdude somerandomdude commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removing justify as an alignment option to simplify type align.

What to review

Did I miss anything? I'm uncertain if I need to update anything else.


Note

Low Risk
Narrowing a public type may break consumers that still pass align="justify", but the change is limited to UI typography alignment options.

Overview
Removes justify from the shared TEXT_ALIGN constant in TextAlign.ts, so the TextAlign union and typography align prop only allow left, center, and right.

Because typographyProps.align uses TEXT_ALIGN as its allowed values, this change propagates automatically to typography components—align="justify" is no longer valid at the type level or in prop validation.

Reviewed by Cursor Bugbot for commit 9dd686a. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9dd686a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Actions Updated
sanity-ui-storybook Ignored Ignored Oct 30, 2026 4:57pm UTC
sanity-ui-workshop Ignored Ignored Oct 30, 2026 4:57pm UTC
ui-docs Ignored Ignored Oct 30, 2026 4:57pm UTC
ui-studio Ignored Ignored Oct 30, 2026 4:57pm UTC

Request Review

@colepeters colepeters left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did a quick check to see if anything else needed to be pruned. Turns out we didn't even have a CSS class for justify so I don't think this ever worked to begin with 😅

@somerandomdude
somerandomdude merged commit b88c3f6 into v5-alpha Oct 30, 2026
15 of 16 checks passed
@somerandomdude
somerandomdude deleted the fix-remove-justify-alignment branch October 30, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants