You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: remove justify from alignment options - #3286
Removing justify as an alignment option to simplify type align.
What to review
Did I miss anything? I'm uncertain if I need to update anything else.
Note
Low Risk
Narrowing a public type may break consumers that still pass align="justify", but the change is limited to UI typography alignment options.
Overview
Removes justify from the shared TEXT_ALIGN constant in TextAlign.ts, so the TextAlign union and typography align prop only allow left, center, and right.
Because typographyProps.align uses TEXT_ALIGN as its allowed values, this change propagates automatically to typography components—align="justify" is no longer valid at the type level or in prop validation.
Reviewed by Cursor Bugbot for commit 9dd686a. Bugbot is set up for automated code reviews on this repo. Configure here.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I did a quick check to see if anything else needed to be pruned. Turns out we didn't even have a CSS class for justify so I don't think this ever worked to begin with 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing
justifyas an alignment option to simplify type align.What to review
Did I miss anything? I'm uncertain if I need to update anything else.
Note
Low Risk
Narrowing a public type may break consumers that still pass
align="justify", but the change is limited to UI typography alignment options.Overview
Removes
justifyfrom the sharedTEXT_ALIGNconstant inTextAlign.ts, so theTextAlignunion and typographyalignprop only allowleft,center, andright.Because
typographyProps.alignusesTEXT_ALIGNas its allowed values, this change propagates automatically to typography components—align="justify"is no longer valid at the type level or in prop validation.Reviewed by Cursor Bugbot for commit 9dd686a. Bugbot is set up for automated code reviews on this repo. Configure here.