Pin rng type to avoid templating all rng functions - #67
Merged
logantm2 merged 9 commits intoJul 1, 2026
Conversation
Collaborator
Author
|
So for the BGK stuff, I wanna write a class with a virtual function that accepts an RNG. The problem is that all of our current functions that accept RNGs are templated on the RNG type, but you can't make a virtual function template. This PR just picks an RNG type so that all those templates can be removed, and puts it in one place so that it can be swapped out at compile time easily. |
logantm2
marked this pull request as ready for review
June 19, 2026 00:40
reuterb
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.