Skip to content

feat(reflect): add timeline-first workflow reflection#83

Merged
samzong merged 26 commits into
samzong:mainfrom
zhexulong:main
Jul 8, 2026
Merged

feat(reflect): add timeline-first workflow reflection#83
samzong merged 26 commits into
samzong:mainfrom
zhexulong:main

Conversation

@zhexulong

@zhexulong zhexulong commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add official recall-reflect extension for timeline-first workflow reflection
  • keep agent-facing Reflect workflow in skills/reflect
  • remove core recall reflect workflow/report logic so core remains data-plane + protocol only

Boundary

Reflect consumes Recall through CLI JSON/JSONL protocol and does not read SQLite or depend on Recall Rust internals.

Verification

  • cargo test -p recall-reflect
  • cargo test
  • cargo fmt --check
  • cargo clippy --all-targets -- -D warnings
  • cargo build -p recall-reflect
  • cargo run -p recall-reflect -- --recall-extension-manifest
  • cargo run -- skill install --dry-run --yes

@samzong

samzong commented Jul 7, 2026

Copy link
Copy Markdown
Owner

@zhexulong Thanks for your contribution! I think this is a great initiative.

I’m currently considering how Recall can support various business scenarios without becoming bloated, so I’m looking into a plugin or extension mechanism. I believe this presents a perfect opportunity for that.

I’m working on the design now. Once finalized, I’ll review your PR and provide a more detailed response within days

@zhexulong

Copy link
Copy Markdown
Collaborator Author

@zhexulong Thanks for your contribution! I think this is a great initiative.

I’m currently considering how Recall can support various business scenarios without becoming bloated, so I’m looking into a plugin or extension mechanism. I believe this presents a perfect opportunity for that.

I’m working on the design now. Once finalized, I’ll review your PR and provide a more detailed response within days

Great, I also think that some features in Recall are currently bundled together, and decoupling them would be a better approach. I'm very much looking forward to your plugin mechanism design. Once the design is finalized, I'll adjust my PR accordingly. Feel free to reach out if you need any help.

@samzong

samzong commented Jul 7, 2026

Copy link
Copy Markdown
Owner

@zhexulong Thanks for waiting. The extension design has now landed in #85:

https://github.com/samzong/Recall/blob/main/docs/extensions.md

Given that direction, I think reflect should not land as a core recall reflect subcommand in its current form. The preferred path is to reshape it as the first official extension, likely recall-reflect, while keeping any agent-facing workflow in skills/reflect.

Please take a look at docs/extensions.md and adjust this PR around that boundary. If the current CLI JSON/JSONL protocol is not enough for reflect, we can discuss the smallest data-only core primitive needed, but the workflow/report/calibration logic should stay out of core.

@zhexulong

Copy link
Copy Markdown
Collaborator Author

Thanks — adjusted around the extension boundary from docs/extensions.md.

The PR now keeps Reflect workflow/report/pattern logic in the official recall-reflect extension, leaves core as the data-plane/protocol host, and keeps skills/reflect as the agent-facing workflow. The extension consumes Recall through CLI JSON/JSONL output rather than Rust internals or SQLite.

I first moved the implementation into the extension and verified parity, then removed the old core recall reflect command and core report module.

@samzong

samzong commented Jul 8, 2026

Copy link
Copy Markdown
Owner

@zhexulong thanks update!

I optimized recall export in #97 . I think you can use this to reduce unnecessary data processing.

recall export --include metadata,messages

@samzong

samzong commented Jul 8, 2026

Copy link
Copy Markdown
Owner

@zhexulong a little suggestions:

  • Move doc to docs/extensions/reflect.md
  • Place the skill in the skills folder for now. I’m considering unified installation for multiple skills (including kitup), but your approach is great—let me think on it further.

@zhexulong zhexulong requested a review from samzong as a code owner July 8, 2026 08:39
@zhexulong

Copy link
Copy Markdown
Collaborator Author

Thanks! Updated the PR around the latest feedback.

Changes in the latest update:

  • moved the Reflect PRD from docs/reflect.md to docs/extensions/reflect.md
  • updated recall-reflect to call recall export --include metadata,messages so Recall only emits the fields Reflect needs

@samzong

samzong commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Can we hold off the "skills" change for now?

@zhexulong

Copy link
Copy Markdown
Collaborator Author

Can we hold off the "skills" change for now?

Just to clarify: by holding off the “skills” change, do you mean:

  1. keep skills/reflect in the repo, but do not wire it into recall skill install yet; or
  2. remove/hold skills/reflect from this PR entirely for now?

@samzong

samzong commented Jul 8, 2026

Copy link
Copy Markdown
Owner

option 1, do not wire it into recall skill install yet.

@samzong samzong merged commit 594220f into samzong:main Jul 8, 2026
6 checks passed
@samzong

samzong commented Jul 8, 2026

Copy link
Copy Markdown
Owner

@zhexulong are you interested in joining the recall contributors? It looks like there is still quite a bit of work to do to maintain this part of reflect.

@samzong samzong linked an issue Jul 8, 2026 that may be closed by this pull request
@zhexulong

Copy link
Copy Markdown
Collaborator Author

@zhexulong are you interested in joining the recall contributors? It looks like there is still quite a bit of work to do to maintain this part of reflect.

Thanks for asking — I appreciate the invitation.

I’m happy to keep contributing through PRs where I can. I may not have the bandwidth to help maintain Recall/Reflect long-term right now, but I’d be glad to continue helping with focused changes.

@samzong

samzong commented Jul 8, 2026

Copy link
Copy Markdown
Owner

@zhexulong I've sent out the invitation. Please check youremail.

and recall just ship v0.3.0 right now, you can use recall ext install reflect to enjoy it.

asciicast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance: timeline-first reflection for AI coding workflows

2 participants