Skip to content

Clarify stats output by counting source files #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanfowler merged 1 commit into from
Mar 10, 2026
Merged

Clarify stats output by counting source files #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ fn main() {
let took = start.elapsed();

eprintln!(
"Compressed {} files in {}",
stats.num_files,
"Compressed {} source files in {}",
stats.num_source_files,
format_duration(took)
);
eprintln!("Data compression:");
Expand Down
8 changes: 4 additions & 4 deletions src/precompress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ impl Algorithms {

#[derive(Debug, Clone, Copy, Default)]
pub(crate) struct Stats {
pub(crate) num_files: u64,
pub(crate) num_source_files: u64,
pub(crate) num_errors: u64,

pub(crate) brotli: AlgStat,
Expand All @@ -119,7 +119,7 @@ impl std::ops::Add<Stats> for Stats {

fn add(self, rhs: Stats) -> Stats {
Stats {
num_files: self.num_files + rhs.num_files,
num_source_files: self.num_source_files + rhs.num_source_files,
num_errors: self.num_errors + rhs.num_errors,
brotli: self.brotli + rhs.brotli,
deflate: self.deflate + rhs.deflate,
Expand Down Expand Up @@ -286,7 +286,7 @@ impl Compressor {
}

if compressed {
stats.num_files += 1;
stats.num_source_files += 1;
}
}
}
Expand Down Expand Up @@ -543,7 +543,7 @@ mod tests {
compressor.precompress(&root, &WalkOptions::default())?;
let stats = compressor.finish();

assert_eq!(stats.num_files, 1);
assert_eq!(stats.num_source_files, 1);
assert!(stats.brotli.total_bytes > 0);
assert!(stats.gzip.total_bytes > 0);
assert_eq!(stats.deflate.total_bytes, 0);
Expand Down